account-financial-tools
account-financial-tools copied to clipboard
OCA
[14.0][MIG] account_spread_cost_revenue
@astirpe I have made the migration of the module out of your PR. Most seem ok. Except here, https://github.com/OCA/account-financial-tools/pull/1244/files#diff-c57937ecf6269df4b995260fb68911ef84a4c3d11f51ab5aa91f5144d705ea52R40
I need to add this as v13 is allowed to reconciled without posted state, but not in v14.
May I explain the main point of change on this MIG,
Odoo 13 Odoo can reconcile move lines, even on state "draft". And so, the logic and test was also to prove that. (which actually not quite correct in my opinion).
Odoo 14 Only reconcile after posting document (from both side, invoice and spread move)
- https://github.com/OCA/account-financial-tools/pull/1244/commits/470d872ff65a797aa6aa308a79d2334c577a7bb0#diff-c57937ecf6269df4b995260fb68911ef84a4c3d11f51ab5aa91f5144d705ea52L38-L39
- https://github.com/OCA/account-financial-tools/pull/1244/commits/470d872ff65a797aa6aa308a79d2334c577a7bb0#diff-50788f2526bc0ec75ae627daa97d005c29444834c499e006b0ea77f79d57d6a9R501-R502
- https://github.com/OCA/account-financial-tools/pull/1244/commits/470d872ff65a797aa6aa308a79d2334c577a7bb0#diff-e279bec9360828ba2ebeb82a3b26b82424e049b4a6e547c1d74aa5cbaa7b81c4R16-R20
Looks like new account numbering of v14 cause problem. When create_move() this module use Description from spread table as Number of Journal Entry. And it always conflict with the pattern of v14.
May be we need to use odoo numbering system (MISC/...) instead?
@astirpe WDYT?
I made a quick test locally and it seems working fine! I would like to spend some extra time to test more in deep, unless there are other contributors who want to do that.
@kittiu, I can't test this PR in on runboat since it still refer to runbot instead of runboat. It functionally works well in my local. Can we merge this ?
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1244-by-kittiu-bump-nobump, awaiting test results.
@kittiu your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1244-by-kittiu-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@kittiu your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1244-by-kittiu-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
