account-financial-reporting icon indicating copy to clipboard operation
account-financial-reporting copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[IMP][14.0][account_financial_report] Add landscape report option to Open Items

Open driehuis opened this issue 2 years ago • 5 comments

The Open Items report has a lot of information packed into one line. This pull request adds a landscape option to the report for legibility.

driehuis avatar Apr 07 '22 22:04 driehuis

I'll see if I can remove the -0.01% of code coverage introduced by this patch.

driehuis avatar Apr 07 '22 22:04 driehuis

Hmmm, seems like the actual report generation is not tested at all.

driehuis avatar Apr 10 '22 09:04 driehuis

Actually generating a report in the test has bumped code coverage for open_items.py from 7% to 53%, and ensured that all added code has been tested.

driehuis avatar Apr 12 '22 12:04 driehuis

Even more test coverage for open_items.py. Still no 100% line coverage, but at least all functions seem to be hit by a test now (and because open_items.py deals with a lot of corner cases, a metric buttload of code is needed to reach 100% coverage). Anyway, I'm unlikely to further improve test coverage for this module in the short term.

driehuis avatar Apr 12 '22 23:04 driehuis

Frustratingly, these tests worked for me on my system... I'll hunt for the regression and fix it.

driehuis avatar Apr 20 '22 16:04 driehuis

@OCA/accounting-maintainers this PR is ready to be merged, anyone else want to review it? If not I proceed with the merge considering the module development_status is Beta.

tafaRU avatar Nov 30 '22 09:11 tafaRU

Please @driehuis could add some screenshot or mini-video? 🙏

rafaelbn avatar Nov 30 '22 16:11 rafaelbn