account-closing icon indicating copy to clipboard operation
account-closing copied to clipboard

[16.0][FIX] account_cutoff_accrual_sale : Fixes for SO invoiced on order + [ADD] support for down payment

Open jbaudoux opened this issue 11 months ago • 2 comments

I added pleeeeenty of tests !

Covering:

  • normal service on order : should be invoiced when SO is confirmed
  • shipping service on order : should be invoiced when first stock delivery occurs (that's a specificity of delivery module https://github.com/odoo/odoo/blob/16.0/addons/delivery/models/sale_order.py#L155)
  • stock product on order : should be invoiced when delivered (invoicing policy doesn't matter here, accrual is based on stock valuation change, i.e. the effective stock delivery)

cc @rousseldenis @lmignon @sbidoul

Also fixed account_cutoff_accrual_order_base that was updating stock in the test while not depending on stock module. Code moved to modules depending on this one and stock

Edit: I also added support for downpayment

jbaudoux avatar Feb 12 '25 16:02 jbaudoux

@lmignon @rousseldenis This needs review

jbaudoux avatar Mar 13 '25 09:03 jbaudoux

@alexis-via @sbidoul Can you merge this one?

jbaudoux avatar Mar 27 '25 11:03 jbaudoux

@sbidoul and merge this one also

jbaudoux avatar Apr 15 '25 15:04 jbaudoux

/ocabot merge minor

sbidoul avatar Apr 15 '25 16:04 sbidoul

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-326-by-sbidoul-bump-minor, awaiting test results.

OCA-git-bot avatar Apr 15 '25 16:04 OCA-git-bot

Congratulations, your PR was merged at cd99d1ba03fafcb8a983152bf74ede6ed997c812. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Apr 15 '25 16:04 OCA-git-bot