account-analytic icon indicating copy to clipboard operation
account-analytic copied to clipboard

[18.0] [MIG] analytic_partner: Migration to 18.0

Open AmalBenAissa opened this issue 4 months ago • 8 comments

Migration module analytic_partner to version 18.0

AmalBenAissa avatar Aug 26 '25 15:08 AmalBenAissa

Hi @AmalBenAissa Can you squash your commits plz?

DorianMAG avatar Aug 28 '25 07:08 DorianMAG

Hi @AmalBenAissa Can you squash your commits plz?

hello @DorianMAG thanks for the request that is done

AmalBenAissa avatar Aug 28 '25 09:08 AmalBenAissa

ping @OCA/accounting-maintainers any chance to have a merge here ?

flotho avatar Aug 29 '25 12:08 flotho

ping @AmalBenAissa , some changes are requested, could you fix SVP ?

flotho avatar Nov 07 '25 08:11 flotho

@Saran440 done , could you check please ?

AmalBenAissa avatar Dec 10 '25 12:12 AmalBenAissa

@AmalBenAissa Thanks for the fix. Please read the instructions here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#how-to and then open a new PR or force push to this PR.

Saran440 avatar Dec 11 '25 02:12 Saran440

Hi @Saran440,

Could you clarify the problem? Is it necessary to squash the last commit?

It seems the history was preserved correctly.

Best regards

DorianMAG avatar Dec 11 '25 09:12 DorianMAG

@DorianMAG

Could you clarify the problem?

  • Reviewer can't review the code difference between the original history and the new commit.

Is it necessary to squash the last commit?

  • The history commit should come first, and then the migration commit, so reviewers can clearly check the code changes.

However, if the maintainer is fine with this PR, I’m fine with it too.

Saran440 avatar Dec 12 '25 02:12 Saran440