[18.0] [MIG] analytic_partner: Migration to 18.0
Migration module analytic_partner to version 18.0
Hi @AmalBenAissa Can you squash your commits plz?
Hi @AmalBenAissa Can you squash your commits plz?
hello @DorianMAG thanks for the request that is done
ping @OCA/accounting-maintainers any chance to have a merge here ?
ping @AmalBenAissa , some changes are requested, could you fix SVP ?
@Saran440 done , could you check please ?
@AmalBenAissa Thanks for the fix. Please read the instructions here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#how-to and then open a new PR or force push to this PR.
Hi @Saran440,
Could you clarify the problem? Is it necessary to squash the last commit?
It seems the history was preserved correctly.
Best regards
@DorianMAG
Could you clarify the problem?
- Reviewer can't review the code difference between the original history and the new commit.
Is it necessary to squash the last commit?
- The history commit should come first, and then the migration commit, so reviewers can clearly check the code changes.
However, if the maintainer is fine with this PR, I’m fine with it too.