account-analytic icon indicating copy to clipboard operation
account-analytic copied to clipboard

[16.0][ADD] analytic_mixin_analytic_accounts_and_plans

Open norlinhenrik opened this issue 1 year ago • 3 comments

This PR is based on #565. See also PR 1207 for account_financial_report.

account.move.line new fields:

  • analytic_account_ids (useful for account_financial_report)
  • analytic_account_names (introduced in #565)
  • analytic_plan_ids (introduced by me)
  • analytic_plan_names (for consistency, but I don't need it)

The compute method in account_financial_report (AGPL) is written for stored fields, with good performance. The compute method in #565 (LGPL) is written for non-stored fields.

QUESTIONS

  1. If account_financial_report depends on this module for analytic_account_ids, will the performance suffer?
  2. If no dependency, and both modules introduce analytic_account_ids, can both be used in the same database?
  3. What should be the module name?

norlinhenrik avatar Jul 21 '24 21:07 norlinhenrik

Please avoid plurals in module names, and I would say that this requires a shorter name that summarizes the goal of the module.

pedrobaeza avatar Jul 21 '24 22:07 pedrobaeza

I suggested "accounts" and "plans" since they are many2many fields. But I am fine with "account" and "plan".

What would be a good shorter name?

  • analytic_account_and_plan?
  • analytic_account_and_plan_mixin?
  • analytic_mixin_fields?

norlinhenrik avatar Jul 22 '24 05:07 norlinhenrik

What about analytic_unfolding_mixin?

pedrobaeza avatar Jul 22 '24 06:07 pedrobaeza

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Nov 24 '24 12:11 github-actions[bot]