OCA
[17.0][MIG] purchase_request_analytic: Migration to 17.0
For lack of a 16.0 version, the migration from analytic_account_id to analytic_distribution is done here.
@StefanRijnhart Thanks. Maybe changes could have been put in separate commit in order to be backported ?
@rousseldenis I don't have time for that but it should be easy for the person who requires the module to work on 16.0
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
I mean, merge this now and if for some reason it is added in 16.0 create a new PR to remove the migration scripts here.
@AaronHForgeFlow Thanks for clarifying! As for removing the script once a 16.0 module is published, we don't even have to do that as it would break the migration of people who migrate from 15 to 17 using the Odoo enterprise migration service like me. As it is, the migration script already checks if the field was created previously (in a future 16.0 version of this module) and then does nothing.
I know it is a pain for the ones that migrate with the enterprise service. But I think it is a "rule" to delete migrations folders of older versions when doing a migration (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0). Perhaps you can open a separate discussion in regards that topic. I am not against merging this now, so I will not block the PR because of it.
@AaronHForgeFlow you are right, I will open that discussion if the matter becomes concrete again.
This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-671-by-dreispt-bump-nobump, awaiting test results.
It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-671-by-dreispt-bump-nobump, awaiting test results.
Congratulations, your PR was merged at de6237ff048b8e63931d4c9cc4fae17119bb7b55. Thanks a lot for contributing to OCA. ❤️