account-analytic icon indicating copy to clipboard operation
account-analytic copied to clipboard

[16.0][FIX] stock_analytic: use standard method to get stock valuation account

Open tli-asl opened this issue 1 year ago • 4 comments

This commit fixes the direct access to the value of property_stock_valuation_account_id defined in the product category of the product of the move. This commit gets the account using the get_product_accounts() method to improve inheritability and consistency with the standard code base.

tli-asl avatar Jun 13 '24 12:06 tli-asl

Hi all,

As this is my very first OCA PR, I don't know who to ping. I checked the last PR's, and it seems you, @pedrobaeza @dreispt, are really pro-active, would it be possible to review this one ?

Your comments will be more than welcome !

Thanks in advance !

Cc: @iaj-asl @it-ideas

tli-asl avatar Jun 13 '24 13:06 tli-asl

The authors/maintainers of the module may review it. You can review other PRs and ask in exchange that they review yours.

pedrobaeza avatar Jun 13 '24 13:06 pedrobaeza

Hey @tli-asl 👋 Good to see you here 🤩

IT-Ideas avatar Jun 13 '24 19:06 IT-Ideas

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 18 '24 12:06 OCA-git-bot

/ocabot merge patch

dreispt avatar Aug 22 '24 09:08 dreispt

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-665-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar Aug 22 '24 09:08 OCA-git-bot

Congratulations, your PR was merged at 3d9aaac435fde6a9389c501f060995f56e088f82. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Aug 22 '24 09:08 OCA-git-bot