account-analytic icon indicating copy to clipboard operation
account-analytic copied to clipboard

[15.0][FIX] purchase_request_analytic: fill analytic account id in the purchase request

Open AaronHForgeFlow opened this issue 1 year ago • 1 comments

When all the purchase request lines has the same analytic account the purchase request analytic account has to be the same.

This change fills analytic account id in the purchase request when all the lines have same analytic account id.

Before this change the analytic account is empty in those cases, and because of that, the search of purchase request by analytic account is not working

cc @ForgeFlow

AaronHForgeFlow avatar Mar 19 '24 11:03 AaronHForgeFlow

@ps-tubtim is this ok to you?

AaronHForgeFlow avatar May 03 '24 11:05 AaronHForgeFlow

Would it be possible to add a small test?

StefanRijnhart avatar Jul 04 '24 14:07 StefanRijnhart

@StefanRijnhart small tests added :) sorry for the diff, took the opportunity to rename a variable name

AaronHForgeFlow avatar Jul 04 '24 15:07 AaronHForgeFlow

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 04 '24 18:07 OCA-git-bot

/ocabot merge patch

StefanRijnhart avatar Jul 04 '24 18:07 StefanRijnhart

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-636-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot avatar Jul 04 '24 18:07 OCA-git-bot

Congratulations, your PR was merged at d6fe93f00bf22ce2677d3d54ec2824bbba2bce5c. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 04 '24 18:07 OCA-git-bot