account-analytic icon indicating copy to clipboard operation
account-analytic copied to clipboard

[14.0] product_analytic_sale

Open alexis-via opened this issue 2 years ago • 3 comments

The readme gives an example of a scenario where this module product_analytic_sale is required.

alexis-via avatar Jun 07 '22 16:06 alexis-via

@alexis-via I just found a bug in case the Sale Order Line as no product_id (type note). I added a commit to fix it. cc @rvalyi

clementmbr avatar Jun 13 '22 14:06 clementmbr

It should be great to add a little test.

rousseldenis avatar Jun 13 '22 16:06 rousseldenis

This works +1

As @rousseldenis , it could be great a little test #462 (comment)

My curiosity / question is , why not improve product_analytic with this so we don't need glue modules? I complicated so we need another module

@rafaelbn This to avoid a strong dependency on sale in product_analytic

rousseldenis avatar Aug 16 '22 05:08 rousseldenis

/ocabot merge nobump

dreispt avatar Oct 01 '22 14:10 dreispt

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-462-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 01 '22 14:10 OCA-git-bot

Congratulations, your PR was merged at 3b0ffc5564d7fa8a4ad40fc5a2f7d484e12202cd. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 01 '22 14:10 OCA-git-bot