account-analytic icon indicating copy to clipboard operation
account-analytic copied to clipboard

[14.0][ADD] account_analytic_required_never

Open rousseldenis opened this issue 3 years ago • 4 comments

When creating account move lines, don't fill in analytic account (even if passed in parameters) if analytic policy is set to 'Never'

rousseldenis avatar May 17 '22 14:05 rousseldenis

@sanrav @adrienpeiffer

rousseldenis avatar May 17 '22 14:05 rousseldenis

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 25 '22 12:09 github-actions[bot]

@OCA/accounting-maintainers

rousseldenis avatar Sep 28 '22 13:09 rousseldenis

I don't understand the difference with https://github.com/OCA/account-analytic/blob/14.0/account_analytic_required/models/account.py#L17

    property_analytic_policy = fields.Selection(
        selection=[
            ("optional", "Optional"),
            ("always", "Always"),
            ("posted", "Posted moves"),
            ("never", "Never"),

The question is:

  • Without this module if account_analytic_required is set to "never" and the analytic account is set then de account.move has analytic
  • With this module if account_analytic_required is set to "never" and the analytic account is set then de account.move has NOT analytic

Is it?

Thank you!

rafaelbn avatar Sep 28 '22 14:09 rafaelbn

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 29 '23 12:01 github-actions[bot]