OpenUpgrade icon indicating copy to clipboard operation
OpenUpgrade copied to clipboard

[17.0][OU-ADD] account: migration to 17.0

Open daiduongnguyen-odoo opened this issue 1 year ago • 4 comments

daiduongnguyen-odoo avatar Jun 13 '24 06:06 daiduongnguyen-odoo

/ocabot migration account

Depends on :

  • product : #4598
  • analytic : #4597
  • digest : #4642

pedrobaeza avatar Jun 13 '24 06:06 pedrobaeza

@flachica Hello, i apply your fix here, please notify me if you have something in your mind :v

daiduongnguyen-odoo avatar Jun 27 '24 06:06 daiduongnguyen-odoo

@flachica Hello, i apply your fix here, please notify me if you have something in your mind :v

I will close my PR and internally use this branch. Thanks for you amazing work.

flachica avatar Jun 27 '24 07:06 flachica

Hello, I'm creating a new analysis tool called odoo-module-diff, it's explained here: https://github.com/akretion/odoo-module-diff

To review or complete the PR, you might be interested by these key commits of the account module migration to 17.0: https://github.com/akretion/odoo-module-diff-analysis/tree/main/17.0/account

rvalyi avatar Jul 09 '24 07:07 rvalyi

I'll create a followup-PR next Monday of nobody else has picked this up until then

hbrunn avatar Oct 28 '24 15:10 hbrunn

I'll create a followup-PR next Monday of nobody else has picked this up until then

Thank you sir

daiduongnguyen-odoo avatar Oct 29 '24 01:10 daiduongnguyen-odoo

I didn't manage to finish this today, so I just pushed an intermediate version on my fork. ~~Still working on a correct payment term migration,~~ Payment terms and tax groups should be fine already.

hbrunn avatar Nov 04 '24 20:11 hbrunn

@hbrunn is this finished on your side (or on hold)? It's for resuming from here.

pedrobaeza avatar Nov 07 '24 20:11 pedrobaeza

my comments from https://github.com/OCA/OpenUpgrade/pull/4457#discussion_r1819149393 down need addressing still, so if you've the time, please resume from there

hbrunn avatar Nov 07 '24 22:11 hbrunn

PS: I'll continue with this on Monday if I don't hear anything to the contrary

hbrunn avatar Nov 08 '24 13:11 hbrunn

I'm today resuming this, so probably it will be done. I'll tell you.

pedrobaeza avatar Nov 08 '24 13:11 pedrobaeza

I don't find any new commits on https://github.com/Tecnativa/OpenUpgrade/commits/17.0-account - what are you working on so that I can do something else today?

hbrunn avatar Nov 11 '24 04:11 hbrunn

I'm still working on this.

pedrobaeza avatar Nov 11 '24 07:11 pedrobaeza

today?

hbrunn avatar Nov 11 '24 07:11 hbrunn

Yes, I will push my result at the end of the morning.

pedrobaeza avatar Nov 11 '24 07:11 pedrobaeza

great, then I'll pick it up from there and do some more reviews meanwhile

hbrunn avatar Nov 11 '24 07:11 hbrunn

?

hbrunn avatar Nov 11 '24 13:11 hbrunn

I have opened https://github.com/OCA/OpenUpgrade/pull/4662, but it's still not finished. I'm just stuck at the new invoice_label to fill proper data. I have reviewed/reworked till https://github.com/OCA/OpenUpgrade/pull/4662/files#diff-22f22a0c72f96258826774abe5ffb855f21883cf30e51b7e81fbcaaca048214aR275

pedrobaeza avatar Nov 11 '24 14:11 pedrobaeza