OBOFoundry.github.io icon indicating copy to clipboard operation
OBOFoundry.github.io copied to clipboard

Campaign to standardize synonym types

Open cthoyt opened this issue 9 months ago • 5 comments

This is an "epic" issue, just as a placeholder to reference various efforts towards standardizing synonym type definitions across the OBO Foundry

Background

These are the two precursor discussions in the OMO tracker where we talked about starting to encode synonym type definitions in OMO:

  1. https://github.com/information-artifact-ontology/ontology-metadata/issues/70
  2. https://github.com/information-artifact-ontology/ontology-metadata/issues/122

Updating OMO

Here are issues/PRs where we added standards to OMO:

  • https://github.com/information-artifact-ontology/ontology-metadata/issues/151
  • https://github.com/information-artifact-ontology/ontology-metadata/pull/124
  • https://github.com/information-artifact-ontology/ontology-metadata/pull/133
  • https://github.com/information-artifact-ontology/ontology-metadata/pull/140
  • https://github.com/information-artifact-ontology/ontology-metadata/issues/146 / https://github.com/information-artifact-ontology/ontology-metadata/pull/152
  • https://github.com/information-artifact-ontology/ontology-metadata/issues/148
  • https://github.com/information-artifact-ontology/ontology-metadata/pull/150
  • https://github.com/information-artifact-ontology/ontology-metadata/pull/159

Specifically, see the template: https://github.com/information-artifact-ontology/ontology-metadata/blob/master/src/templates/annotation_properties.tsv

Ontology Issues/Updates

Ontology updates/issues, where we updated an ontology to conform to the standard

Uberon

  • https://github.com/obophenotype/uberon/issues/3058 / https://github.com/obophenotype/uberon/issues/3080 (duplicate issue) / https://github.com/obophenotype/uberon/pull/3083
  • https://github.com/obophenotype/uberon/issues/3079 / https://github.com/obophenotype/uberon/pull/3082
  • https://github.com/obophenotype/uberon/pull/3077
  • https://github.com/obophenotype/uberon/pull/3113

CL

  • https://github.com/obophenotype/cell-ontology/issues/2150 / https://github.com/obophenotype/cell-ontology/pull/2159

ZFA

  • https://github.com/ZFIN/zebrafish-anatomical-ontology/pull/173

NCBITaxon

  • https://github.com/obophenotype/ncbitaxon/pull/88

ENVO

  • https://github.com/EnvironmentOntology/envo/pull/1465

XAO

  • https://github.com/xenopus-anatomy/xao/pull/62

PO

  • https://github.com/Planteome/plant-ontology/pull/722

HP

  • https://github.com/obophenotype/human-phenotype-ontology/issues/10140 / https://github.com/obophenotype/human-phenotype-ontology/pull/10241

ChEBI

  • https://gitlab.ebi.ac.uk/chembl/chebi/chebi-2.0/chebi-ontology-generator/-/issues/27

cthoyt avatar Sep 23 '23 11:09 cthoyt

Thank you!!!

On Sat, Sep 23, 2023 at 4:00 AM Charles Tapley Hoyt < @.***> wrote:

This is an "epic" issue, just as a placeholder to reference various efforts towards standardizing synonym type definitions across the OBO Foundry

These are the two precursor discussions in the OMO tracker where we talked about starting to encode synonym type definitions in OMO:

  1. information-artifact-ontology/ontology-metadata#70 https://github.com/information-artifact-ontology/ontology-metadata/issues/70
  2. information-artifact-ontology/ontology-metadata#122 https://github.com/information-artifact-ontology/ontology-metadata/issues/122

Here are issues/PRs where we added standards to OMO:

Specifically, see the template: https://github.com/information-artifact-ontology/ontology-metadata/blob/master/src/templates/annotation_properties.tsv

Ontology updates/issues, where we updated an ontology to conform to the standard:

— Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/2450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOLU3KKR35W45D4JS2LX326MBANCNFSM6AAAAAA5EDX7SQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cmungall avatar Sep 25 '23 14:09 cmungall

I need some methodological help here, how I can weigh the arguments of @hoganwr on #148 ("universal or near universal substitutabilty") against yours "useful for X, eg Chebi"?

In other words, how will we decide, moving forward, what is a valid synonym type to avoid overloading the concept? In the current sense, even "first name" could become a synonym type. Can we have a clear definition of synonym type before we move on to add all these?

matentzn avatar Nov 22 '23 16:11 matentzn

We are only two ontologies away from being done with my initial list! HPO needs some more hand-holding, and ChEBI will be possible if we can decide to push through the synonym types they need to encode different kinds of chemical synonyms.

There's still more to do. For example, PRO and NCBITaxon both require some more work since they have a big variety of synonyms, some of which could probably be ontologized differently (or really would never make sense as a "standardized" or "externalized" synonym). PO is misusing synonyms to denote languages. There are probably other things floating around too!

cthoyt avatar Jan 24 '24 23:01 cthoyt

I need some methodological help here, how I can weigh the arguments of @hoganwr on #148 ("universal or near universal substitutabilty") against yours "useful for X, eg Chebi"?

I want to counter this wrt the BRAND_NAME discussion, since many ontologies import chebi and therefore accidentally mint their own version, I think that there is always a case to be made for externalizing synonym types, and anyone who wants to be a stakeholder can participate in the discussion board here when someone proposes one

cthoyt avatar Feb 21 '24 11:02 cthoyt

It occurs to me here that there are term "types", and there are "synonym" types. What are we discussing here specifically?

Brand name is suitable as a term type, but it is not a good synonym type.

Bill

On Wed, Feb 21, 2024 at 5:54 AM Charles Tapley Hoyt < @.***> wrote:

I need some methodological help here, how I can weigh the arguments of @hoganwr https://github.com/hoganwr on #148 https://github.com/OBOFoundry/OBOFoundry.github.io/issues/148 ("universal or near universal substitutabilty") against yours "useful for X, eg Chebi"?

I want to counter this wrt the BRAND_NAME discussion, since many ontologies import chebi and therefore accidentally mint their own version, I think that there is always a case to be made for externalizing synonym types, and anyone who wants to be a stakeholder can participate in the discussion board here when someone proposes one

— Reply to this email directly, view it on GitHub https://github.com/OBOFoundry/OBOFoundry.github.io/issues/2450#issuecomment-1956489775, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJR55QEZOJSNVZAF5U4SRLYUXN7ZAVCNFSM6AAAAAA5EDX7SSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGQ4DSNZXGU . You are receiving this because you were mentioned.Message ID: @.***>

hoganwr avatar Feb 21 '24 15:02 hoganwr