OAuthSwift icon indicating copy to clipboard operation
OAuthSwift copied to clipboard

Remove showing the network activity status, deprecated sind iOS 13

Open cmittendorf opened this issue 3 years ago • 2 comments

This change removes changing the network activity indicator as the necessary api has been marked as deprecated in iOS 13.

Besides the old solution was not safely being called on the main thread, the OAUTH_APP_EXTENSIONS build flag is of no use when being used as a swift package.

cmittendorf avatar Apr 29 '22 11:04 cmittendorf

Apple has deprecated it since iOS 13. May be it is time to remove it from the library entirely?

@property(nonatomic,getter=isNetworkActivityIndicatorVisible) BOOL networkActivityIndicatorVisible API_UNAVAILABLE(tvos) API_DEPRECATED("Provide a custom network activity UI in your app if desired.", ios(2.0, 13.0));

vgritsenko avatar Jul 13 '22 17:07 vgritsenko

Yes, the functionality should be removed completely. I totally missed that the api is deprecated. I've updated my PR.

cmittendorf avatar Jul 20 '22 11:07 cmittendorf