OAuthSwift icon indicating copy to clipboard operation
OAuthSwift copied to clipboard

Added parsing of id_token, if present in access token response

Open colinhumber opened this issue 4 years ago • 4 comments

Adds support for parsing of id_token, if present, when fetching an access token. Details on why this is useful is in https://github.com/OAuthSwift/OAuthSwift/issues/668, specifically to support Single Sign Out with a redirect URI.

colinhumber avatar Oct 07 '21 14:10 colinhumber

Hi,

Ok we just decode it if present and store it in memory into OAuthSwiftCredential

No need to store it ? in keychain for instance with other credential object informations

There is support of Codable and old NSCoder too

ps: I could merge anyway but could wait

phimage avatar Oct 08 '21 09:10 phimage

I missed encoding/decoding with Codable and NSCoder support on OAuthSwiftCredential. I'll add that in.

colinhumber avatar Oct 08 '21 14:10 colinhumber

Is this still being looked at? I also need the id_token for single sign-out so would appreciate the merge!

MikeSpelling avatar Jan 10 '22 11:01 MikeSpelling

Any reason this is still unmerged?

MikeSpelling avatar Jul 07 '22 13:07 MikeSpelling

Same question, why still unmerged? This would be very usable, because the library seems to lack proper logout and id_token is needed to acheive that via manually requests

ramden avatar Dec 11 '23 12:12 ramden