OAuthSwift icon indicating copy to clipboard operation
OAuthSwift copied to clipboard

Make TimeoutInterval configurable to fix issue OAuthSwift/issues/667

Open MikeSpelling opened this issue 4 years ago • 3 comments

Rather than providing a default timeout in the Config initialiser which is never overriden I've moved this up to the top level requests. This should mean its a non-breaking change but allows a timeoutInterval to be passed where needed and used by the UrlRequest. This is my first open source contribution so I welcome any feedback - thanks!

MikeSpelling avatar Aug 12 '21 16:08 MikeSpelling

@phimage any thoughts on this PR?

MikeSpelling avatar Aug 19 '21 12:08 MikeSpelling

Any update on this as yet?

MikeSpelling avatar Jan 10 '22 11:01 MikeSpelling

A thought from a peanut gallery... This seems to add an extra parameter into a lot of methods. Wouldn't it be better to subclass OAuthSwiftClient and override open makeRequest function and tailor request to your needs in there? It would need a few small changes to OAuthSwiftHTTPRequest, but it would result in much less changes overall.

vgritsenko avatar Jul 13 '22 18:07 vgritsenko