OAuthSwift icon indicating copy to clipboard operation
OAuthSwift copied to clipboard

👷🏻‍♀️ Run Danger on GitHub Action

Open phatblat opened this issue 4 years ago • 3 comments

The Travis build is always blowing up with a "Bad credentials" error.

GET https://api.github.com/repos/OAuthSwift/OAuthSwift/pulls/659: 401 - Bad credentials // See: https://docs.github.com/rest (Octokit::Unauthorized)

Not sure how well this is going to work in a GitHub Action workflow, but with the automatic availability of the GITHUB_TOKEN for an action, it sure seems simpler to manage.

phatblat avatar May 19 '21 18:05 phatblat

The success from the new Danger check is misleading as there was an error running swiftlint.

From https://github.com/OAuthSwift/OAuthSwift

  • [new branch] ci/action/danger -> origin/ci/action/danger /home/runner/work/OAuthSwift/OAuthSwift/vendor/bundle/ruby/2.6.0/gems/danger-swiftlint-0.26.0/ext/swiftlint/bin/swiftlint: 1: Syntax error: "(" unexpected

I didn't realize this was also going to run swiftlint, so will need to switch to a macOS runner.

phatblat avatar May 19 '21 18:05 phatblat

Does danger still need to run SwiftLint, given that it already runs in its own action?

Nef10 avatar May 20 '21 06:05 Nef10

I have never configured it, but I see danger SwiftLint, I have already launch SwiftLint on linux , I see some docker and GitHub action about it

phimage avatar May 20 '21 13:05 phimage