Mark-Oliver Junge comments

Results 15 comments of


                                            Mark-Oliver Junge

Implement `Spanned` to retrieve source locations on AST nodes

Hey all, think we've gotten quite far here - is there anything actively blocking this from getting approved? Are there any actions I can take to help you guys or...

Implement `Spanned` to retrieve source locations on AST nodes

Okay, I wrote some documentation and fixed up the tests so CI should pass now (I hope :P ) Let me know what you think of the docs, I wasn't...

Implement `Spanned` to retrieve source locations on AST nodes

Thanks for the great review. I was definitely a bit sloppy yesterday (Monday 🤮). I merged main again if you want to give that a quick review as well. :)

Implement `Spanned` to retrieve source locations on AST nodes

I also noticed that there is a bunch of calls to `::fmt` which seems quite strange to me. Not sure what the test is doing, but I don't think the...

Create test pattern for Spans

> /edit to add: I guess it's because `Spanned for Value` is not implemented yet. But even if it were, I'm not sure the function span will cover all the...