dsn icon indicating copy to clipboard operation
dsn copied to clipboard

Sub-delimiters incorrectly matched

Open verdy-p opened this issue 1 year ago • 1 comments

The closing brace } is NOT allowed as a valid "sub-delim" character, but the closing parenthese ) is missing.

See RFC RFC3986 annex A, and pull request https://github.com/Nyholm/dsn/pull/26

verdy-p avatar Sep 17 '22 21:09 verdy-p

Note that with this change, you could still not support ODBC-style DSN's (which require {} braces as alternate delimiters to enclose names containing spaces or as a way to enclose and escape other delimiters) like: Driver={ODBC Driver 13 for SQL Server};server=localhost;database=WideWorldImporters;trusted_connection=Yes;

But a few other DSN's would be working now (notably those using () parentheses). May be braces could be allowed as well (but the current code does not check their pairing for correct enclosure: this requires an additional validation rule that cannot use basic regexps, but requires a stack for LALR parsing).

verdy-p avatar Oct 01 '22 10:10 verdy-p