ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(themes): add missing themes

Open davimmt opened this issue 1 year ago • 14 comments

image

davimmt avatar Mar 25 '24 13:03 davimmt

Related to this theme.

davimmt avatar Mar 25 '24 13:03 davimmt

@davimmt i think it'll be better for us to automate this part! like a github workflow which will update types on push.

cuz more themes need to be added https://nvchad.com/news/v2.5_release#new_themes

but themes are located in base46 repo!

so i think the automation must be added in base46 repo and it'll push to this UI repo's nvchad_types dir

siduck avatar Mar 25 '24 13:03 siduck

so i wont merge this yet. same thing needs to be done with the highlight groups

siduck avatar Mar 25 '24 13:03 siduck

Just run the generator for that :)

lucario387 avatar Mar 25 '24 13:03 lucario387

Agreed. Opened to raise awareness, at minimum.

davimmt avatar Mar 25 '24 14:03 davimmt

Just run the generator for that :)

this?

https://github.com/NvChad/ui/blob/v2.5/scripts/update-nvchad-types.lua

So this must be done when staying in nvim itself right?

siduck avatar Mar 25 '24 14:03 siduck

or nvim -l scripts/update-nvchad-types.lua

lucario387 avatar Mar 25 '24 15:03 lucario387

or nvim -l scripts/update-nvchad-types.lua

Hey, can you confirm this command works on your machine? because on mine it errors out:

$ nvim -l scripts/update-nvchad-types.lua        
E5113: Error while calling lua chunk: scripts/update-nvchad-types.lua:5: module 'base46' not found:
	no field package.preload['base46']
	no file './base46.lua'
	no file '/usr/share/luajit-2.1/base46.lua'
	no file '/usr/local/share/lua/5.1/base46.lua'
	no file '/usr/local/share/lua/5.1/base46/init.lua'
	no file '/usr/share/lua/5.1/base46.lua'
	no file '/usr/share/lua/5.1/base46/init.lua'
	no file './base46.so'
	no file '/usr/local/lib/lua/5.1/base46.so'
	no file '/usr/lib/lua/5.1/base46.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
	[C]: in function 'require'
	scripts/update-nvchad-types.lua:5: in main chunk

But the require error goes away if I do it from within with :luafile :thinking:

KorigamiK avatar May 27 '24 03:05 KorigamiK

because base46 is not loaded on startup.

lucario387 avatar May 27 '24 04:05 lucario387

@KorigamiK what about opening nvim and just running :lua filepath...

siduck avatar May 27 '24 04:05 siduck

because base46 is not loaded on startup. I added this to my config:

  {
    "NvChad/base46",
    lazy = false,
  },

image

And yet, I get the same error.

KorigamiK avatar May 27 '24 04:05 KorigamiK

@KorigamiK yea didnt work. can you just open nvim and run :luafile filepath that worked for me

siduck avatar May 27 '24 04:05 siduck

@siduck That's true, I was trying to do this in the command line so I can add this generator to the CI for the repo

KorigamiK avatar May 27 '24 04:05 KorigamiK

Forgot im running it from a different version :D But the gists is that base46 is not found in rtp during nvim -l unless you set it beforehand

I think the script should be reworked to be CI-only

lucario387 avatar May 27 '24 04:05 lucario387

i no longer face that issue, its fixed

siduck avatar Oct 03 '24 14:10 siduck