base46 icon indicating copy to clipboard operation
base46 copied to clipboard

nvim-dap-ui controls background doesn't match icons.

Open andg-odoo opened this issue 1 year ago • 3 comments

Describe the bug The highlight group for the nvimdap ui background winbar is black even though the icons respect the colorscheme. Honestly not sure if this is more on their end or here.

To Reproduce Steps to reproduce the behavior:

  1. Install nvim-dap-ui
  2. Configure M.ui with a supported theme. Add M.base46 integration for dap
M.ui = { theme = "catppuccin" }
M.base46 = { integrations = { "dap" }, }
  1. Enable integration:
require('base46').get_integration("dap")
dofile(vim.g.base46_cache .. "dap")
  1. Enable toggle on ui and see issue.

Expected behavior The winbar color should match the colorscheme.

Screenshots image

Desktop (please complete the following information):

  • Ubuntu 24.04
  • Gnome Terminal
  • nvim 0.10.0

andg-odoo avatar Sep 18 '24 17:09 andg-odoo

color that dark bg too? it must have a hlgroup

siduck avatar Sep 19 '24 00:09 siduck

https://github.com/NvChad/base46/blob/v2.5/lua/base46/integrations/dap.lua

siduck avatar Sep 19 '24 00:09 siduck

send pr there

siduck avatar Sep 19 '24 00:09 siduck

i dont use dap , but it seems to be fixed from recent pr image

siduck avatar Jan 15 '25 14:01 siduck