news-summarizer icon indicating copy to clipboard operation
news-summarizer copied to clipboard

UI Features and linting

Open skeptrunedev opened this issue 2 years ago • 1 comments

I did more than @Nutlope explicitly asked for in https://github.com/Nutlope/news-summarizer/pull/1, but none of these are breaking changes and I think that they all add value.

However, if there are objections to any of them, please request changes and I will edit the PR. Thanks!

  • [x] Makes API request on paste
  • [x] Makes API request on enter
  • [x] Errors in all appropriate places
  • [x] Stops loading on error
  • [x] Put generateSummary into a callback: just a performance optimization and best practice
  • [x] Add linting: knowing that beginners will hopefully fork this repo or use it as reference, I think it's very important to add linting. There were warnings in the dependencies arrays in the [...slug].tsx file that linting picked up in the current version of main.
  • [x] Add prettier: The prettier-plugin-tailwindcss was already installed. However, without including it in a config file, some VIM and VSCode configurations won't pick it up. Imo, having it explicitly referenced in the config is best practice.

https://user-images.githubusercontent.com/15804464/217460593-f1f15aa4-7cb7-48f7-a750-4555590798bf.mp4

skeptrunedev avatar Feb 08 '23 07:02 skeptrunedev

@kmkhami is attempting to deploy a commit to the Hassanteam Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 08 '23 07:02 vercel[bot]