aicommits icon indicating copy to clipboard operation
aicommits copied to clipboard

feat: add maximum length flag (#91)

Open ceIia opened this issue 1 year ago • 2 comments

adding the length flag in reference to #91.

i assumed the default value of the maximum length according to the 50/72 rule, but of course this is still an opinionated change and should be discussed according to what you guys think!


i still have an issue though with commands/prepare-commits-msg-hook.ts, should it:

  1. pass the length as an argument from cli.ts to generateCommitMessage,
  2. hardcode the length inside the generateCommitMessage invocation,
  3. make the length argument optional with a default value of 50 (or something else)
  4. something better around the process.argv.slice line? (probably bad for maintainability)

thx for reading!

ceIia avatar Mar 01 '23 21:03 ceIia

I really want this feature, but sadly it has conflicts.

vetan2 avatar Mar 17 '23 04:03 vetan2

@ceIia Can you update the PR to resolve conflicts?

Also, can you make the maximum length a config property instead of a flag?

privatenumber avatar Mar 20 '23 17:03 privatenumber

sure!

ceIia avatar Mar 24 '23 13:03 ceIia