aicommits
aicommits copied to clipboard
feat: add maximum length flag (#91)
adding the length flag in reference to #91.
i assumed the default value of the maximum length according to the 50/72 rule, but of course this is still an opinionated change and should be discussed according to what you guys think!
i still have an issue though with commands/prepare-commits-msg-hook.ts
, should it:
- pass the length as an argument from
cli.ts
togenerateCommitMessage
, - hardcode the length inside the
generateCommitMessage
invocation, - make the length argument optional with a default value of 50 (or something else)
- something better around the
process.argv.slice line
? (probably bad for maintainability)
thx for reading!
I really want this feature, but sadly it has conflicts.
@ceIia Can you update the PR to resolve conflicts?
Also, can you make the maximum length a config property instead of a flag?
sure!