ember-data-resources icon indicating copy to clipboard operation
ember-data-resources copied to clipboard

Getting deprecation warning when switching to Ember 6

Open jbescoyez opened this issue 6 months ago • 1 comments

I get the following deprecation message after switching to Ember 6:

DEPRECATION: Importing `inject` from `@ember/service` is deprecated. Please import `service` instead. [deprecation id: importing-inject-from-ember-service] This will be removed in ember-source 7.0.0. See https://deprecations.emberjs.com/id/importing-inject-from-ember-service for more details.

Which is due to this line: https://github.com/NullVoxPopuli/ember-data-resources/blob/ac7136b097637cd5183eb57a1384a534ec2cd681/ember-data-resources/src/-private/resources/request.ts#L5

I would be happy to submit a PR, however, I have no idea how to conditionally import files and more specifically, how to test the Ember version.

Let me know if I can help.

jbescoyez avatar Apr 28 '25 05:04 jbescoyez

A PR would be most helpful!

The deprecation guide explains what to do:

https://deprecations.emberjs.com/id/importing-inject-from-ember-service

NullVoxPopuli avatar Apr 28 '25 12:04 NullVoxPopuli

Here it is: https://github.com/NullVoxPopuli/ember-data-resources/pull/434

jbescoyez avatar May 05 '25 10:05 jbescoyez

This can be closed I think.

bertdeblock avatar May 16 '25 10:05 bertdeblock