NullVoxPopuli

Results 2058 comments of NullVoxPopuli

I'd like to block on on using data attributes for classes instead of classes.

Closing this because it turned out to not be relevant

Closing, because https://github.com/glimmerjs/glimmer-vm/pull/1606 solved a lot

> duration phase estimated improvement -110ms woah, that's nice -- Suppose I should compare with the other versions

The improvement revealed by tracerbench translates all they way through to ember. ![image](https://github.com/user-attachments/assets/3a3660c0-bd81-49b0-930d-c11942a2948d) ![image](https://github.com/user-attachments/assets/9763030c-c231-4d32-af35-6f641a0b1989) ![image](https://github.com/user-attachments/assets/7b9a9236-bb5c-48cd-9e40-01730c87dd1c)

Closing, because https://github.com/glimmerjs/glimmer-vm/pull/1606 solved a lot

Some preliminary improvement here (development mode): ![image](https://github.com/user-attachments/assets/27df01ea-5e25-4abf-ae09-5a7e3956210c) (at the cost of type safety)

In production mode, it looks like we get back to 5.6 performance https://glimmer-vm-testing-3.ember-performance-testing-prod.pages.dev/?benchmarks=%5B%22Render%20complex%20html%20(%40glimmer%2Fcomponent)%22%2C%22Render%20complex%20html%20(template-only)%22%5D&emberVersions=%5B%225.5%22%2C%225.6%22%2C%225.7%22%2C%225.8%22%2C%225.9%22%2C%225.10%22%2C%22ember-canary%22%2C%22ember-canary-custom%22%5D ![image](https://github.com/user-attachments/assets/f0ee9fd0-546a-4762-a22f-e21e5c3dd72c)

> It seems like these were intended to be stripped/strippable in prod/turned into no-op, any idea why that isn’t happening? (or maybe the stripping was just never implemented?) I think...

> https://github.com/glimmerjs/glimmer-vm/pull/1602 it's perhaps not just terser, or we need more inlining or something. Or maybe it's possible that the way the checks are written -- they just aren't strippable....