NullVoxPopuli

Results 2058 comments of NullVoxPopuli

From @chancancode : > [rather than `|| delegate`] we need to add a hook that custom modifier managers can implement

For reference, the most recent upgrade pr (tho, this shipped in ember 5.9): - https://github.com/emberjs/ember.js/pull/20658/files#diff-d623b88e623b92ef29d2233d8e1afa4899bcf6f92e28ada00fb6d8c2700d9d69 We went from 0.87.1 to 0.92.0 Likely suspects: - https://github.com/glimmerjs/glimmer-vm/pull/1560 - https://github.com/glimmerjs/glimmer-vm/pull/1565 - https://github.com/glimmerjs/glimmer-vm/pull/1573 Also,...

@davidtaylorhq are those benches all with classic builds? I'm curious how using vite could affect the resulting score. As i look through the changelog in ember, the only things that...

dang, that looks real nice @patricklx 🎉

Mixed news so far - 🎉 I've converted the codebase to be fully "normal", using only public APIs, and templates are compiled at build time: https://github.com/NullVoxPopuli/ember-performance/ - 🎉 I've been...

Second update, after fixing some things: - using `renderSettled` to determine when rendering is done rather than runloop's schedule 'afterRender') - I made a big mistake in how I was...

Just added canary / 5.12 (these are production results) ![image](https://github.com/user-attachments/assets/bf974855-8cdb-4c1f-8a70-cdd6989c7abf)

Pixel 6a Chrome ![Screenshot_20240809-211510](https://github.com/user-attachments/assets/5e8651cb-9ae4-4a3f-807e-c6896b6782ce) FireFox ![Screenshot_20240809-211530](https://github.com/user-attachments/assets/3d371dc6-d05a-4aef-89ce-cecc3d917d2b)

Did a memory allocation timeline and the graph looked like this: ![image](https://github.com/user-attachments/assets/386fe1a4-8b1b-45ce-a96c-ba153079e1c3) which aligns with the work from @bendemboski in https://github.com/glimmerjs/glimmer-vm/pull/1440 which was released in 5.7: https://github.com/emberjs/ember.js/releases/tag/v5.7.0 Nice work, @bendemboski...

So far: - 5% to 9% improvement: https://github.com/glimmerjs/glimmer-vm/pull/1598 - 0.3% to 1% improvement: https://github.com/glimmerjs/glimmer-vm/pull/1597 - pending: https://github.com/glimmerjs/glimmer-vm/pull/1599