NullVoxPopuli
NullVoxPopuli
Is the aspect needed? Running vitest from the repo root seems to find tests in all the sub packages?
yeah, I think first, perhaps bazel would need to be removed :thinking: or someone that knows bazel better would need to take on this work
best advice I can give is to not override things this way (app-tree merging was a mistake! :see_no_evil: ). better to use a separately named thing, separate from the addon...
~~is there any way you could add a test for this so the regression doesn't re-introduce itself?~~ Though, I guess because https://github.com/ember-cli/ember-cli-terser/pull/266 didn't contain any tests, we can't be sure...
cc @rwjblue and @kellyselden ? idk who to tag :sweat_smile:
@st-h can you describe what sort of sourcemaps you are expecting? - hi-fi pre-babel sourcemaps? - or just "good enough" pre-terser sourcemaps?
is it feasible for you to just use the older version? The thing is that #266 fixed issue #265, so to revert #266 will re-break #265.
I think at this point we just have two versions folks use depending on the problem the users are facing. Until someone understands and can debug and fix both problems...
ESBuild had the same issue here: https://github.com/NullVoxPopuli/ember-cli-esbuild/pull/61 and I'm testing out moving broccoli-asset-rev to addon.before right now.
Does the problem still exist if broccoli-terser-sourcemap is upgraded to 4.1.1 in your lockfile?