Nucleus icon indicating copy to clipboard operation
Nucleus copied to clipboard

[v3] Allow Nucleus to display first plugin on cause stack when reporting command usage

Open NickImpact opened this issue 5 years ago • 1 comments

What are you trying to do? A clear and concise description of what you're requesting and why you're requesting it. Ex. I'm always frustrated when [...]

  • To help avoid future occurrences of users believing Nucleus is responsible for some commands being run, and tossing the blame around as if it's a hot potato, perhaps consider supplying the first plugin on the cause stack responsible for running the command, if the source is the server itself.

Describe the solution you'd like A clear and concise description of what you want to happen.

  • Rather than [nucleus] Server ran the command: ..., we could have [nucleus] {{plugin}} ran the command: .... This would need to also consider that we are indeed running as the Server in some cases (control panels, etc.). So likely solution is to first check if there is a plugin responsible on the cause stack, then proceed.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

  • Keep to the current format of just reporting the server as responsible.

Anything else that might help? Add any other context or screenshots about the feature request here.

  • None at this present moment

NickImpact avatar Dec 19 '20 01:12 NickImpact

Turns out we can do this on v2. The SendCommandEvent is an event, and as such has the cause stack! I've gone for something like this in v2:

image

(Note that the plugin and Server are currently the wrong way around here, and will be fixed)

Basically - I'll print out any plugin or CommandSource in the stack. You can see /sudo is simply from the server, but the /ping command that is executed is via the server (as the invoker of /sudo) and then Nucleus (as the plugin that processes /sudo).

I'll do something similar in v3.

dualspiral avatar Dec 30 '20 17:12 dualspiral