bladeRF icon indicating copy to clipboard operation
bladeRF copied to clipboard

flash_image.c: fix `clang` build

Open trofi opened this issue 1 month ago • 1 comments

Without the change the build fails on `clang as:

/build/bladeRF/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35:
  error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
   71 |                 if (val[i] >= 'a' || val[i] <= 'f') {
      |                     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

I think it flags real error. Let's use && to catch the range.

trofi avatar Nov 15 '25 22:11 trofi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 15 '25 22:11 CLAassistant