NuKeeper icon indicating copy to clipboard operation
NuKeeper copied to clipboard

feat: Support custom templates for commits + PRs

Open CrispyDrone opened this issue 5 years ago • 11 comments
trafficstars

:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Feature.

:arrow_heading_down: What is the current behavior?

All commit messages, and pull request title and body templates are hardcoded.

:new: What is the new behavior (if this is a feature change)?

This commit introduces mustache templates for commit messages, and pull request titles and bodies.

The design consists of templates with predefined properties. A custom template can be provided.

Stubble has been chosen as the template renderer.

It is possible to define additional context for the templates, this also includes delegates. These can be provided as the value of a "_delegates" key in the context.

:boom: Does this PR introduce a breaking change?

No.

:bug: Recommendations for testing

Creation of pull requests and commits.

:memo: Links to relevant issues/docs

N/A

:thinking: Checklist before submitting

  • [X] All projects build
  • [X] Relevant documentation was updated

CrispyDrone avatar Oct 24 '20 14:10 CrispyDrone

will this feature be merged?

clooudch avatar Nov 07 '20 16:11 clooudch

I am very interested in the ability to set custom templates for commit messages and PR titles. We have a requirement to put a JIRA ticket number in both of these places.

csMACnz avatar Dec 21 '20 22:12 csMACnz

I'm also interested in this; seems like a relatively small change too!

caffeineinc avatar Dec 21 '20 22:12 caffeineinc

Rebased to incorporate new changes on master and fix conflicts.

CrispyDrone avatar Jan 23 '21 18:01 CrispyDrone

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 23 '21 20:04 stale[bot]

Heya, what needs done to get this functionality added? This still remains a dealbreaker of using this tool for us.

csMACnz avatar Apr 23 '21 23:04 csMACnz

We are very interested in having custom commit messages, as we are using conventional commits to automatically set our version.

We are able to invest time into this feature. How to go on with this PR? What's missing? How can we help?

msallin avatar Jun 05 '21 17:06 msallin

Any news? Still ready to help, if necessary.

cc org members: @slang25 @shep1987 @MarcBruins @AnthonySteele

msallin avatar Aug 23 '21 13:08 msallin

For those which are looking for the corresponding issue (closed because of inactivity): https://github.com/NuKeeperDotNet/NuKeeper/issues/897

msallin avatar Aug 28 '21 10:08 msallin

@CrispyDrone can you please rebase the branch on the latest master?

msallin avatar Sep 20 '21 16:09 msallin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 20 '21 06:12 stale[bot]