NuGetGallery icon indicating copy to clipboard operation
NuGetGallery copied to clipboard

[Feature]: Could you please add "www.infragistics.com" to allowed domains list for images?

Open jsakamotoIGJP opened this issue 2 years ago • 7 comments

Related Problem

We want to use images in our product NuGet packages' readme, but the URLs of those images are under the "www.infragistics.com" domain (ex. https://www.infragistics.com/products/ignite-ui-blazor/blazor/images/general/getting-started-blazor-card.jpg). Unfortunately, "www.infragistics.com" is not listed in the allowed domains list of nuget.org, so we can't use those images in our NuGet package readme.

The Elevator Pitch

You said "please feel free to file an issue", so we send this request. Thanks in advance.

Additional Context and Details

No response

jsakamotoIGJP avatar Apr 09 '24 12:04 jsakamotoIGJP

@lyndaidaii Could you please provide the link to the process?

@jsakamotoIGJP Please look at previous example for it: https://github.com/NuGet/NuGetGallery/pull/9857

erdembayar avatar Apr 09 '24 17:04 erdembayar

@jsakamotoIGJP , thank you for providing feedback. Is there any package you own on NuGet.org have readme with www.infragistics.com with images? Currently, we didn't see any customer include image with www.infragistics.com domain. Please let us know about the intention, thanks.

lyndaidaii avatar Apr 09 '24 18:04 lyndaidaii

Hi @lyndaidaii, Thank you for your prompt response!

We have not yet included images whose URL is under the "www.infragistics.com" domain in a README of our published NuGet packages. One of our published NuGet packages is in the following URL.

  • https://www.nuget.org/packages/IgniteUI.Blazor.Trial

We will update our published NuGet packages soon to include a README with images under that domain, so I requested this feature. I have attached the README document file, which we will include in our NuGet packages.

🗒️README_Trial_Blazor.md

I hope that this reply is helpful for the reviewing process.

jsakamotoIGJP avatar Apr 10 '24 08:04 jsakamotoIGJP

@lyndaidaii any updates? thanks!

jsakamotoIGJP avatar Apr 22 '24 23:04 jsakamotoIGJP

Thanks for providing details. The domain looks fine to include. Feel free to create the PR to include this domain. Add domain into this json file. https://github.com/NuGet/NuGetGallery/blob/main/src/NuGetGallery/App_Data/Files/Content/Trusted-Image-Domains.json

Thanks, please let us know if you have any other question.

lyndaidaii avatar May 14 '24 00:05 lyndaidaii

Thanks, @lyndaidaii, I sent a pull request, #9947.

jsakamotoIGJP avatar May 14 '24 08:05 jsakamotoIGJP

Related issue: https://github.com/NuGet/NuGetGallery/issues/10198

erdembayar avatar Oct 16 '24 03:10 erdembayar