WatermelonDB icon indicating copy to clipboard operation
WatermelonDB copied to clipboard

Common mistakes docs

Open esbenp opened this issue 5 years ago • 3 comments

Ref #612

I gave it a try @radex . I am having a hard time coming up with a great example that demonstrates "do not put await between prepareUpdate and batch. This is the best I could come up with, but it also includes a logic flaw (since comments.fetch() would not include the newly updated comments and therefore total_good_comments is wrong). Do you have any feedback for a better example and/or better wordings?

esbenp avatar Jan 31 '20 13:01 esbenp

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 29 '20 14:07 stale[bot]

Just wanted to say thanks. I actually found this helpful, and it enabled me to solve a bug I was having.

I don't think it's super obvious (?) that prepareUpdates can't be called multiple times in the same batch for the same record. Maybe this could be signalled in the docs somehow, or maybe the pull request could be accepted?

olliewd avatar Jul 25 '21 21:07 olliewd

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Apr 27 '22 21:04 stale[bot]