vkQuake icon indicating copy to clipboard operation
vkQuake copied to clipboard

Crash with RT shadows enabled on newest AMD Drivers

Open dumbcatposter opened this issue 1 year ago • 8 comments

Describe the bug Upon starting the game normally, the game tries to load the attract mode demo and crashes to desktop. I built the project from source in Visual Studio and narrowed it down to a stack overflow in r_brush.c:2318. Just to be safe I DDU'ed my drivers and reinstalled them to no avail.

To Reproduce

  • DDU display drivers
  • Install latest AMD Adrenalin software from AMD
  • Start the game
  • Ouchie

Expected behavior The game loads maps without crashing.

Screenshots If applicable, add screenshots to help explain your problem. Screenshot of the Call stack

Desktop (please complete the following information):

  • OS: Windows 11
  • AMD Radeon 7900 XTX
  • Driver version 24.6.1, Vulkan instance version 1.3.261

Mod Vanilla Quake, Steam release

dumbcatposter avatar Jul 18 '24 02:07 dumbcatposter

In other circumstances, I would have said that it is very likely a driver bug, given the effort done to have clean Vulkan usage.

Now where it crashes is maybe the most recent, and the least used part of the engine that is the RT shadows.

Does the crash happens if you disable them by r_rtshadows 0 ?

I've no mean to reproduce anyway being in either Intel / Nvidia and without RT here, so we need a competent AMD user.

vsonnier avatar Jul 19 '24 05:07 vsonnier

If I add r_rtshadows 0 to my autoexec.cfg, the game does indeed launch correctly. Weirdly enough, if I turn the dynamic shadows back on afterward, the game doesn't crash.

dumbcatposter avatar Jul 20 '24 00:07 dumbcatposter

I would keep this open, the validation layers aren't that great with RT right now, maybe there is some invalid usage.

Novum avatar Jul 22 '24 05:07 Novum

or ATI cutting corners in their drivers?

Had something similar with Nvidia drivers and had to change the Vulkan/OpenGL present method from Prefer native to Prefer layered on DXGI Swapchain.
vkQuake would freeze by simply switching from vid_fullscreen 0 to 1 or 2 with drivers 535*
this got fixed with newer drivers, but still in arena fights, when lots going on vkquake can lock up.
Never had this issue with the DXGI Swapchain option enabled.

EDIT: last lock up happened with The Dismal Silhouette released in Jan 2024. 3 of 4 attempts would lock up with r_fteparticles 1. Disabling FTE particles with r_fteparticles 0 before the arena fight was a workaround when driver used the native (auto) method.

I think I still have the savegame available. Will try to reproduce with current drivers 560.70.

j4reporting avatar Jul 22 '24 11:07 j4reporting

User @thesockninja reported in #714, (duplicate) :


vkQuake.exe will open a console window for about two seconds, appear to be hunting for a file or driver, and immediately close without an error displayed. Window is not open long enough for me to read what it says.

To Reproduce Attempt to open vkQuake.exe after installing in both ways:

Drag / drop installation utilizing vkQuake-1.31.0_win64.zip into directory structure: C:\users\ (username)\Desktop\vkQuake - vkquake files are all here, with an id1 subdirectory inside with PAK0/PAK1 files pulled from either the Nightdive rerelease (Steam) or an OG Quake CDrom install.

Attempting to open vkQuake.exe after installation using vkQuake-Installer-x64-1.31.0.exe and pointing to the same sourced PAK files (keeping them in the Steam subdirectory) produces the same situation

Expected behavior vkQuake.exe will load from PAK files and start the attract mode / game menu.

Screenshots This is a recent crash in Windows Event Viewer:

image

I have attached the associated WER file as well as associated vkQuake crash dump found in C:\Users(USER)\AppData\Local\CrashDumps in:

vkQuakeBugReport.zip

Desktop: 7800x3d ASrock B650 Livemixer 32GB DDR5-6000 @ 36cl or so 1000w EVGA PSU 1TB Crucial M.2 / NVME (Install Drive / C:)

  • OS: Windows 11
  • GPU: Powercolor Hellhound AMD 7900xtx (stock configuration)
  • issue persists similarly on 24.6.1 and 24.7.1

Mod Nightdive rerelease sourced (classic, rerelease) PAK files, also tried with PAK files sourced from a Quake retail CD, no other mods.

Additional context I did read this bug report, however, I am not sure what "If I add r_rtshadows 0 to my autoexec.cfg, the game does indeed launch correctly." entails specifically or where to perform similar actions for a testable fix.

No issues with any other programs, crashes, or bluescreens. Other sourceports work with the same PAK files. I have a second computer (10700k, RX580 using 24.6.1 and also 24.7.1 later as I was troubleshooting, Windows 10) where this install structure, 1:1 same sourced files, works fine.

Attempted a complete reinstall of the 64-bit vkquake files with both the installer and the raw files. I attempted uninstalling using both windows uninstaller and Wise Program Uninstaller to remove prior, no change in any regard. (This is the cleanest uninstallation method that I can find. If there is a better one, please advise.) Attempted running vkQuake.exe as administrator, no change. Uninstalled (w/ DDU) video drivers, reinstalled, no change. Updated from 24.6.1 to 24.7.1 and both drivers produce the same issue. No settings in the 7900xtx different than the RX580 as far as I can tell from AMD Adrenalin Software.

Please let me know if anything else is needed.

vsonnier avatar Jul 28 '24 06:07 vsonnier

I believe I am seeing this as well. 7900 XTX (drive 24.7.1). If i go back to vkQuake-1.22.3_win64 then it loads fine / no problems. Everything after (vkQuake-1.30.0_win64, vkQuake-1.30.1_win64, vkQuake-1.31.0_win64, vkQuake-1.31.1_win64) = instant crash on load. I have no other crashes or instabilities in any other game or 3D application I use. If I add "r_rtshadows 0" to autoexec.cfg then the crash goes away.

tdimarzio avatar Aug 04 '24 22:08 tdimarzio

Changed the titile to mention RT shadows, since it seems to be the problem here.

vsonnier avatar Aug 05 '24 05:08 vsonnier

I did review the code and didn't see any obvious issues. Latest validation layers also report none.

Novum avatar Aug 06 '24 03:08 Novum

This is no longer occuring in vkQuake. rtshadows set to 0 workaround is no longer required. I assume this issue can be closed. Unfortunately, I don't know which driver version or vkquake version it started working in. I am currently running AMD driver 24.10.1 and vkQuake 1.31.3

tdimarzio avatar Nov 08 '24 23:11 tdimarzio

Thanks @tdimarzio for the report ! 1.31.2 received Vulkan fixes by @Novum, so perhaps that fixed it... maybe combined with recent drivers, who knows ?

Anyway that is a good thing to have RT shadows working for AMD at last.

vsonnier avatar Nov 09 '24 09:11 vsonnier