MSRF-Net icon indicating copy to clipboard operation
MSRF-Net copied to clipboard

Undefined variable in last commit - inputs

Open augustoicaro opened this issue 3 years ago • 4 comments

The last commit uncommented the following line, and the inputs variable is not defined. I didn't figure out the right argument for the Canny method.

https://github.com/NoviceMAn-prog/MSRF-Net/blob/60e23734d94d340b9d89b64e7f9e2636b6f96c0f/model.py#L267

augustoicaro avatar Feb 12 '22 00:02 augustoicaro

Yes, me too. So confusion

PinkR1ver avatar Mar 28 '22 08:03 PinkR1ver

Hello! Do you have any updates on this issue? Thank you!

chrisangelidis avatar Jul 06 '23 08:07 chrisangelidis

Hello @chrisangelidis, for now you you have 3 options.

If you want to test msfr-net:

  • my fork that fixes this repo: https://github.com/augustoicaro/MSRF-Net
  • pytorch implementation: https://github.com/amlarraz/MSRF-Net_PyTorch

The third option is use the last work of the author, the GMSRF-Net, implemented in pytorch.

augustoicaro avatar Jul 06 '23 09:07 augustoicaro

Thank you very much @augustoicaro !!

chrisangelidis avatar Jul 06 '23 12:07 chrisangelidis