react-notion-x icon indicating copy to clipboard operation
react-notion-x copied to clipboard

Person property and person text support

Open inlife opened this issue 4 years ago • 3 comments
trafficstars

Hey @transitive-bullshit

Problem 1

Person property is not rendered in the property list on the top of the page if no other mentions of this user exist on the page below. The error is reported by react-render-x is: missing user 5693XXXX-XXXX-45db-XXXX-a3166058XXXX

notion react-notion-x
image image

Problem 2

As soon as at least a single mention happens on the webpage, the property now gets resolved, with the only problem it rendering only the image without a name text.

Also please note, on the text style the name mention should not even have the image preview and should be rendered as an inline-block but it is treated like a regular block.

notion react-notion-x
image image

Are there ways to provide a custom component for rendering specific properties or persons/users?

Cheers!

inlife avatar Mar 18 '21 11:03 inlife

Thanks @inlife; this is definitely missing functionality in react-notion-x.

PRs are more than welcome 💯

transitive-bullshit avatar Mar 27 '21 16:03 transitive-bullshit

@transitive-bullshit is there any documentation on how to set up a development environment and contribute?

inlife avatar Mar 29 '21 05:03 inlife

@inlife sorry I'm so late on this. https://github.com/NotionX/react-notion-x/blob/master/contributing.md

transitive-bullshit avatar Mar 25 '22 12:03 transitive-bullshit