react-notion-x icon indicating copy to clipboard operation
react-notion-x copied to clipboard

Migrate to pnpm + turbo

Open FranciscoMoretti opened this issue 2 years ago • 3 comments

Description

Just wondering if there is any interest in moving from yarn + lerna to pnpm + turbo.

I've migrated this for myself on a local build and I'm experiencing a better developer experience. The benefits I've got from it are:

  • Faster installs and dev runs
  • Better documentation (pnpm + turbo)
  • Fewer commands. E.g. This command starts dev for the minimal example and the packages that it depends upon: pnpm dev --filter notion-x-example-minimal...

My main motivation: As someone who started learning web development recently, migrating to pnpm + turbo was easier than learning yarn + lerna.

I can open a PR with the basic configuration if there is some interest in the topic. Feel free to close the issue if not.

FranciscoMoretti avatar Feb 03 '23 12:02 FranciscoMoretti

had the same idea messing with next 13 and a lot of things werent playing too nice. Made small changes to the lazy image wrapper which I thought wouldnt be too bad but I kept having trouble building the project. Anyways, tried out the same combo and its working quite nicely react-notion-x-turbo

mustaqimarifin avatar Feb 06 '23 17:02 mustaqimarifin

I'm open to this; will make for a tough PR, though.

transitive-bullshit avatar Feb 14 '23 07:02 transitive-bullshit

PR Created https://github.com/NotionX/react-notion-x/pull/461. You were right, it's a large one.

FranciscoMoretti avatar Apr 08 '23 09:04 FranciscoMoretti