react-notion-x icon indicating copy to clipboard operation
react-notion-x copied to clipboard

Published 20 hours ago • verified publisher icon NotionX

Images are no longer rendering. Looks like the image file format has been changed by Notion

Open pbteja1998 opened this issue 2 years ago • 8 comments

Description

Now, image signed URLs are starting with files.notion.so for some reason and that case is not being handled by the defaultMapImageUrl. Because of this, images are no longer rendering correctly.

Check the below notion page for an example.

Notion Test Page ID

39192dc8661e4776a91cfa5eb37c9499

pbteja1998 avatar Jan 31 '23 12:01 pbteja1998

I have the same problem, any one know how it fix?

james-freec avatar Feb 02 '23 01:02 james-freec

Yeah, I'm seeing this in some pages as well. But not all of them. May just be on new workspaces or something.

normdoow avatar Feb 04 '23 07:02 normdoow

If any of you find a fix, please let us know.

transitive-bullshit avatar Feb 04 '23 09:02 transitive-bullshit

If any of you find a fix, please let us know.

Quick fix I found is using the source from the image block instead of the signed_url image But the signed url is needed because it doesn't expire right?

normdoow avatar Feb 04 '23 09:02 normdoow

Signed URLs expire; maybe we can just use the source directly now? That would be amazing

transitive-bullshit avatar Feb 04 '23 09:02 transitive-bullshit

Hot fix: https://github.com/NotionX/react-notion-x/pull/430

normdoow avatar Feb 04 '23 09:02 normdoow

We will watch this to see how the hot fix performs in other scenarios. Once we learn more about the new notion source we can make a better solution.

normdoow avatar Feb 04 '23 23:02 normdoow

Looks like now even the audio files have signed URLs starting with file.notion.so

Related: https://github.com/NotionX/react-notion-x/issues/441

pbteja1998 avatar Feb 25 '23 01:02 pbteja1998