react-notion-x
react-notion-x copied to clipboard
NotionX
fix: 🐛 add missing property cover
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| react-notion-x | ✅ Ready (Inspect) | Visit Preview | Sep 8, 2022 at 3:32PM (UTC) |
| react-notion-x-minimal-demo | ✅ Ready (Inspect) | Visit Preview | Sep 8, 2022 at 3:32PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@futantan, thanks for this. Could you add a test page id where you are seeing an issue with this? Where are you needing the cover type?
@normdoow For every pages which is a database, the cover property is the cover image url.
Not needed. The data is already there from notion’s api
On Tue, Oct 11, 2022 at 00:01 Noah Bragg @.***> wrote:
@.**** commented on this pull request.
In packages/notion-types/src/collection.ts https://github.com/NotionX/react-notion-x/pull/368#discussion_r991445244 :
@@ -39,6 +39,7 @@ export interface Collection { copied_from: string template_pages?: Array<ID>
- cover?: string;
Looks like you are just adding the cover type. More work probably needs to be done to add this in code.
— Reply to this email directly, view it on GitHub https://github.com/NotionX/react-notion-x/pull/368#pullrequestreview-1136252815, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP2MGJ5DUS6OA2HMB2RM6DWCQ4W5ANCNFSM6AAAAAAQH33DSQ . You are receiving this because you were mentioned.Message ID: @.***>