react-notion-x icon indicating copy to clipboard operation
react-notion-x copied to clipboard

Published 20 hours ago • verified publisher icon NotionX

fix redeclaration of variable in formula calculation

Open utkuturunc opened this issue 2 years ago • 1 comments

Description

let keyword redefined the variable, which set the return value of the entire function to undefined, discarding the calculated value

Notion Test Page ID

067dd719a912471ea9a3ac10710e7fdf

utkuturunc avatar Sep 05 '22 15:09 utkuturunc

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-notion-x ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 3:14PM (UTC)
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 3:14PM (UTC)

vercel[bot] avatar Sep 05 '22 15:09 vercel[bot]

@transitive-bullshit could you check this one please? a lot of code goes unused because this bug just discards the result

utkuturunc avatar Nov 12 '22 09:11 utkuturunc

@utkuturunc looks good. Great catch!

transitive-bullshit avatar Nov 13 '22 05:11 transitive-bullshit

[email protected]

transitive-bullshit avatar Nov 13 '22 05:11 transitive-bullshit