react-notion-x icon indicating copy to clipboard operation
react-notion-x copied to clipboard

defaultMapImageUrl - check for signed URLs

Open marekhvolka opened this issue 4 years ago • 1 comments
trafficstars

Please, can we add a check to the defaultMapImageUrl for the signed URLs? So when we have a signed URL for a specific block, we will use it instead of the native URL. This was the only reason I had to override the mapImageUrl method and I guess, it would be better to have this built-in (it took some time to figure it out as well)

Something like:

if (data.signed_urls && data.signed_urls[block.id]) {
  return data.signed_urls[block.id];
}

marekhvolka avatar Nov 15 '21 14:11 marekhvolka

This is a great idea. Good catch.

transitive-bullshit avatar Mar 25 '22 12:03 transitive-bullshit