notifiarr icon indicating copy to clipboard operation
notifiarr copied to clipboard

fix commands crash, panic: send on closed channel

Open notifiarr-bot opened this issue 2 years ago • 1 comments

also <@178341568279871500> found a panic triggering a command


[ERROR] 2022/07/26 08:46:10 http: panic serving 127.0.0.1:56134: send on closed channel
goroutine 239 [running]:
net/http.(*conn).serve.func1()
    net/http/server.go:1825 +0xbf
panic({0xc3a2a0, 0xe3da50})
    runtime/panic.go:844 +0x258

logs and dets it was pmm update triggered https://gist.github.com/bakerboy448/cbb877692714aa73762ad522a50cf6ac

Origin user: bakerboy448 Origin message: Discord Server Link Reporting user: TwitchCaptain Reporting message: Discord Server Link

notifiarr-bot avatar Jul 26 '22 17:07 notifiarr-bot

I need fresh logs of this happening. If this happened to you, please let me know!

davidnewhall avatar Aug 08 '22 08:08 davidnewhall

Found it. This was happening because the web server was being shut down last. So, a request to invoke a command came in after the command runner was shut down. The fix is to shut down the web server before the command runner.

davidnewhall avatar Aug 18 '22 08:08 davidnewhall