Douglas

Results 251 comments of Douglas

Much simpler - Yes. Just needs to be in a closure to handle the pipeline.

@hydrosIII Ah, apologies for missing the notification on your reply. At least, I assume there was a GitHub app notification - I found it earlier but can't find it now!...

Adding this separately since I didn't want it to get lost in the long answer above. I think you should (if you want), open two enhancement requests: * Allow row-conditions...

> Wow, that was fast. Lol - Yeah, I did a pull and noticed the changes. I branched to do some word-smithing and formatting on the help/doc and was testing...

> Maybe it would be smart to keep only a single implementation around That's my thought as well. Seems to be a better fit for the Cookbook, both in terms...

Put in https://github.com/nushell/nu_scripts/pull/1084 to remove the nu_scripts version. Also updated verbage.

Actually, it looks like there may be multiple regressions/failures now. The failure on main is different from the failure after #16975.

Yes, it's just that I like to sanity check quickly using the toolkit (4-5 minutes) rather than waiting for CI to complete to know if there's something I need to...

On the latest (and the one @weirdan mentioned), it's now a failure in: ```nushell shell::pipeline::commands::external::nu_commands::failed_with_proper_exit_code ``` That's a test where `cargo build | collect | get exit_code` should return `101`...