NotRanged.github.io icon indicating copy to clipboard operation
NotRanged.github.io copied to clipboard

Corrected Japanese file. And accurate Japanese job's order.

Open AzukiShiratama opened this issue 2 years ago • 9 comments

Hi. Thanks for great works!

I corrected the important part of the Japanese file. However, the mathematical part is esoteric and difficult to translate. I will do my best to translate it.

ja.json file is here. https://d.kuku.lu/276hneae3

and...

Can you change Japanese job's order? I'm confused every time. image

木工師 (Carpenter)
鍛冶師 (Blacksmith)
甲冑師 (Armorer)
彫金師 (Goldsmith)
革細工師 (Leatherworker)
裁縫師 (Weaver)
錬金術師 (Alchemist)
調理師 (Culinarian)

AzukiShiratama avatar Jul 13 '23 07:07 AzukiShiratama

Added the translation and I'll see what I can do about reordering later

dazemc avatar Jul 13 '23 08:07 dazemc

Thanks!

Oh, sorry. I found bit mistake.

Please replace this. https://d.kuku.lu/g8pcunzpx

AzukiShiratama avatar Jul 13 '23 08:07 AzukiShiratama

And I found a bug.

"Add crafter class icon to macro" option is not working on Japanese. The Job's name must be Japanese to work.

Current /micon Carpenter classjob

Correct /micon 木工師 classjob

AzukiShiratama avatar Jul 13 '23 08:07 AzukiShiratama

I'll rewrite it to use the locale jsons later today

dazemc avatar Jul 13 '23 09:07 dazemc

Can you translate this string?

"Add crafter class icon to macro"

dazemc avatar Jul 14 '23 06:07 dazemc

Yes, I can.

マクロにクラスアイコンを追加する

AzukiShiratama avatar Jul 14 '23 06:07 AzukiShiratama

Can you review this before I push the commits? I haven't reordered the classes yet. https://dazemc.github.io/ffxiv-craft

dazemc avatar Jul 14 '23 07:07 dazemc

I checked. OK, Perfect!

AzukiShiratama avatar Jul 14 '23 07:07 AzukiShiratama

I pushed the commits into this repo. Please let me know if there is any errors.

It's going to take me a few days to do the reordering because I do not know javascript, let alone angular, I'm just good at pretending. I need to write a function that checks the current translation and then chooses something like allClassesJA instead of the ordered list in allClasses. I can do all this except checking the current translation. This should be relatively easy to someone that knows the language. So, I will keep this open in the meantime. For anyone else that looks, the relative files are;

Dropdown menu (ng-repeat): lines 26 - 33 in views/solver.html

Ordered Class list: lines 4 - 13 in js/services/actions.js

dazemc avatar Jul 14 '23 08:07 dazemc