Alexander Brandes
Alexander Brandes
> Looking good! > > I was looking at doing something similar last year, but never finished it. Here’s the branch if it’s at all helpful - [`master...janfaracik:jenkins:progress-bar-new`?expand=1 (compare)](https://github.com/jenkinsci/jenkins/compare/master...janfaracik:jenkins:progress-bar-new?expand=1). >...
> Not something for this PR but the many svg we include also blow up the html and usually most of them are not really needed (but one never knows)....
> > pipeline-stage-view is closely tied to BO > > How so? AFAICT they're completely unrelated implementations, all they have in common is use stages (`pipeline-stage-step`) to organize content. From...
> In your initial description you have 2 places where you wrote stage-view but meant graph-view I think. > > > I'd like to suggest replacing it with the _**graph-view...
No objections from me, if linting works consistently 👍
> There's been several tests commented out/removed and this is due to the JS behind the Command Palette not being supported by HTMLUnit. Is that still the case with now...
/label ready-for-merge --- This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. Please see the [merge process documentation](https://github.com/jenkinsci/jenkins/blob/master/docs/MAINTAINERS.adoc#merge-process) for...
Hey @CrystallDEV, would you mind addressing the outlined feedback above, please? Thanks in advance!
I don't object against adding that to the PR template, but I feel it may be ignored, people don't update it or we forget to check 🤔
/label ready-for-merge --- This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. Please see the [merge process documentation](https://github.com/jenkinsci/jenkins/blob/master/docs/MAINTAINERS.adoc#merge-process) for...