nvf icon indicating copy to clipboard operation
nvf copied to clipboard

fix(blink-cmp): Extended auto_show type

Open itpropro opened this issue 6 months ago • 6 comments

See https://cmp.saghen.dev/modes/cmdline.html#show-menu-automatically on how to add a function for more control of when the menu actually opens.

itpropro avatar Jun 04 '25 01:06 itpropro

:rocket: Live preview deployed from cb4d8340a172e95069b05f8e62f1c93e9ded859b

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: fix/blink_auto_show

Reruns: 944

github-actions[bot] avatar Jun 04 '25 01:06 github-actions[bot]

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that @NotAShelf ?

itpropro avatar Jun 04 '25 01:06 itpropro

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that

you can but it's not required. The point of setupOpts is so we don't have to add every plugin option out there

horriblename avatar Jun 04 '25 08:06 horriblename

Please ensure that the failing formatting checks (editorconfig and alejandra) pass before we can merge this.

NotAShelf avatar Jun 04 '25 10:06 NotAShelf

This should also apply to cmdline.completion.menu.auto_show, but the cmdline section is not really implemented yet. Should I create a separate PR for that

you can but it's not required. The point of setupOpts is so we don't have to add every plugin option out there

The problem is that this is not consistent. SetupOpts in the blink case cannot be everything, as specific things under there are overwritten by custom options like the presets. So at least the options that are implemented should allow a high amount of customization or a way to overwrite them if need to be adjusted.

itpropro avatar Jun 04 '25 13:06 itpropro

The problem is that this is not consistent. SetupOpts in the blink case cannot be everything, as specific things under there are overwritten by custom options like the presets. So at least the options that are implemented should allow a high amount of customization or a way to overwrite them if need to be adjusted.

Sorry, I don't follow, can you give an example?

horriblename avatar Jun 17 '25 18:06 horriblename