nvf icon indicating copy to clipboard operation
nvf copied to clipboard

ui.border doesn't apply to some floating windows and signature

Open mnpqraven opened this issue 9 months ago • 2 comments

⚠️ Please verify that this bug has NOT been reported before.

  • [x] I checked all existing issues and didn't find a similar issue

Description

lots of windows, including nvf.settings.vim.lsp.mappings.hover have default border if set in the config: Image

but nvf.settings.vim.lsp.mappings.openDiagnosticFloat doesn't have borders Image

and so is signature help (i'm using blink-cmp here) Image

👟 Reproduction steps

programs.nvf.settings.vim = {
    ui = {
      noice = {
        enable = true;
        setupOpts = {
          lsp.progress.enabled = false;
          notify.enabled = false;
        };
      };

      borders.enable = true;
      illuminate.enable = true;
    };
    utility.snacks-nvim = {
      enable = true;
      # https://github.com/folke/snacks.nvim/?tab=readme-ov-file#%EF%B8%8F-configuration
      setupOpts = {
        bigfile.enabled = true;
        input.enabled = true;
        picker.enabled = true;
      };
    };
  };

👀 Expected behavior

all kinds of floating windows have border

😓 Actual Behavior

ui.border doesn't apply to some floating windows and signature

💻 Metadata

  • system: "x86_64-linux" - host os: Linux 6.6.85, NixOS, 24.11 (Vicuna), 24.11.20250405.7819a0d - multi-user?: yes - sandbox: yes - version: nix-env (Nix) 2.24.13 - nixpkgs: /nix/store/v79jbgwmxgiy8m01rhmj4yzn5y507z2c-source

📝 Relevant log output

output of `nvf-print-config`
https://gist.github.com/mnpqraven/fa582eb6c0ee64ea445ec483d5833ed7

mnpqraven avatar Apr 07 '25 13:04 mnpqraven

Note that you can set winborder to get more consistent borders regardless of support in nvf

horriblename avatar Apr 10 '25 06:04 horriblename

ok I have no idea why hover is using our custom borders we didn't set it explicitly ._.

horriblename avatar Apr 10 '25 07:04 horriblename