nvf icon indicating copy to clipboard operation
nvf copied to clipboard

languages/fish: init

Open venkyr77 opened this issue 9 months ago • 4 comments

This PR adds fish language support

Fixes https://github.com/NotAShelf/nvf/issues/792

Testing:

Tested my changes by changing the nvf url to the branch from my fork

nvf.url = "github:venkyr77/nvf/fish-lsp";

with config.vim.languages.fish.treesitter.enable = false,

image

with config.vim.languages.fish.treesitter.enable = true,

image

with config.vim.languages.fish.lsp.enable = false,

image

with config.vim.languages.fish.lsp.enable = true,

image

with config.vim.languages.fish.format.enable = false,

:ConformInfo shows

Formatters for this buffer:
LSP: fish_lsp

with config.vim.languages.fish.format.enable = true,

:ConformInfo shows

Formatters for this buffer:
LSP: fish_lsp
fish_indent ready (fish) /nix/store/j2qz2d900y518k2hq6myl60g2vyh7l19-fish-4.0.1/bin/fish_indent

after :lua require("conform").format(),

image

Sanity Checking

  • [x] I have updated the changelog as per my changes
  • [x] I have tested, and self-reviewed my code
  • [x] My changes fit guidelines found in hacking nvf
  • Style and consistency
    • [x] I ran Alejandra to format my code (nix fmt)
    • [x] My code conforms to the editorconfig configuration of the project
    • [x] My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • [ ] My code includes comments in particularly complex areas
    • [ ] I have added a section in the manual
    • [ ] (For breaking changes) I have included a migration guide
  • Package(s) built:
    • [x] .#nix (default package)
    • [x] .#maximal
    • [x] .#docs-html (manual, must build)
    • [ ] .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • [x] x86_64-linux
    • [ ] aarch64-linux
    • [ ] x86_64-darwin
    • [ ] aarch64-darwin

Add a :+1: reaction to pull requests you find important.

venkyr77 avatar Apr 06 '25 10:04 venkyr77

:rocket: Live preview deployed from 585dfca7ca75c8190bd1596f3ebc6fde6751c7a5

View it here:

Debug Information

Triggered by: venkyr77

HEAD at: fish-lsp

Reruns: 648

github-actions[bot] avatar Apr 06 '25 10:04 github-actions[bot]

We're currently not accepting new language modules into main, as all language modules are in the process of being refactored. Please consider rebasing on the lsp-redesign branch once it is complete in terms of implementation.

NotAShelf avatar Apr 06 '25 16:04 NotAShelf

We're currently not accepting new language modules into main, as all language modules are in the process of being refactored. Please consider rebasing on the lsp-redesign branch once it is complete in terms of implementation.

That makes sense, let me keep the PR in draft state till then so it doesn't clutter the active PRs to look into

venkyr77 avatar Apr 09 '25 21:04 venkyr77

Just FYI, you can now rebase this on the v0.8 branch, although I will happily take this on if you don't plan on doing it.

poseidon-rises avatar Aug 13 '25 22:08 poseidon-rises