NotAFile

Make map generator a generator

2

The map generator is currently just an object that ends up reimplementing the generator API poorly, it would be nice to switch it to an actual generator instead.

Giving all methods etc. with docstrings would be a a good goal, but take very long. Instead, I feel best returns could be gotten from giving all major modules and...

Create new team instances instead of reusing the old ones

2

I mean, we have classes for a reason right? Currently, teams are "reset" with team.initialize. Now, if only there was some standard way to reset a class and intialize it,...

This packet was used to recognize OpenSpades before the version packets were a thing. AFAICT it is pretty much obsolete now.

This is bad in e.g. Arena

Because the Player object is reused between rounds, reloading at the end of the previous round will cause the reload action to be performed in the new game instead of...

Way easier than having to use the weird prefixes.

Since we now have support for the OpenSpades popup dialogs, we can use them in scripts. We might want to have a prettier looking fallback for vanilla, but it's not...

and possibly remove