core-uganda-pilot
core-uganda-pilot copied to clipboard
Cor 484 scopes n claims
thought it would be a good idea to increment the version automatically, but the way this is represented in the authnz frontend is not ideal yet
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: internetti
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [internetti]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
I think that we do not need the Scan
or Value
methods in the api
package, since those methods are only called by the database driver to convert to and from a value that comes from and to the database!
I think that we do not need the Scan or Value methods in the api package, since those methods are only called by the database driver to convert to and from a value that comes from and to the database!
the Value method seems to be needed there, if it's missing, the update fails with cannot convert {6 map[a:b]} to Bytea
@internetti: Adding label do-not-merge/contains-merge-commits
because PR contains merge commits, which are not allowed in this repository.
Use git rebase
to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I think that's because we don't convert from the api
types to the store
types... Because only 1 of these need to be converted to/from the database. I can check with you tomorrow perhaps ?
@internetti: Adding label do-not-merge/contains-merge-commits
because PR contains merge commits, which are not allowed in this repository.
Use git rebase
to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication