core-uganda-pilot icon indicating copy to clipboard operation
core-uganda-pilot copied to clipboard

Cor 484 scopes n claims

Open internetti opened this issue 2 years ago • 7 comments

COR-484

thought it would be a good idea to increment the version automatically, but the way this is represented in the authnz frontend is not ideal yet

internetti avatar May 18 '22 09:05 internetti

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: internetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

I think that we do not need the Scan or Value methods in the api package, since those methods are only called by the database driver to convert to and from a value that comes from and to the database!

ludydoo avatar May 18 '22 10:05 ludydoo

I think that we do not need the Scan or Value methods in the api package, since those methods are only called by the database driver to convert to and from a value that comes from and to the database!

the Value method seems to be needed there, if it's missing, the update fails with cannot convert {6 map[a:b]} to Bytea

internetti avatar May 18 '22 15:05 internetti

@internetti: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I think that's because we don't convert from the api types to the store types... Because only 1 of these need to be converted to/from the database. I can check with you tomorrow perhaps ?

ludydoo avatar May 18 '22 16:05 ludydoo

@internetti: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jun 01 '22 08:06 sonarqubecloud[bot]