rudder icon indicating copy to clipboard operation
rudder copied to clipboard

Fixes #27905: Webapp complains that node-external-reports is missing a license, but it does not need one (and it doesn't complain)

Open clarktsiory opened this issue 1 month ago • 1 comments

https://issues.rudder.io/issues/27905

The webapp part that renders the notification is the PluginExpirationInfo.scala snippet, the problem is that it contains duplicate logic which should be the same as in the error-handling all defined in PluginError.scala (check expiration date, etc.)

The solution is to add constructors, and re-use validation from PluginError.scala.

Also, it's the opportunity for cleaning the snippets : PluginExpirationInfo and HealthcheckInfo contains dead code (for renderIcon).

clarktsiory avatar Nov 27 '25 17:11 clarktsiory

PR updated with a new commit

clarktsiory avatar Nov 27 '25 17:11 clarktsiory

This PR is not mergeable to upper versions. Since it is "Ready for merge" you must merge it by yourself using the following command: rudder-dev merge https://github.com/Normation/rudder/pull/6751 -- Your faithful QA Kant merge: "To be is to do." (https://ci.normation.com/jenkins/job/merge-accepted-pr/111529/console)

OK, squash merging this PR

clarktsiory avatar Dec 19 '25 09:12 clarktsiory