rudder icon indicating copy to clipboard operation
rudder copied to clipboard
verified publisher icon Normation

Fixes #27114: Many diffs no longer display in event logs

Open clarktsiory opened this issue 6 months ago • 1 comments

https://issues.rudder.io/issues/27114

  • there was an issue reading deserializing some change requests XML
  • the makeDiff way in JS to display diff can simply be replaced by static HTML rendered on the server
  • for other diffs (node properties diff as JSON) we need to return the old and new values in the event log API to apply jsondiffpatch to the values (the API will need a complicated upmerge since https://github.com/Normation/rudder/pull/6073)

clarktsiory avatar Jun 19 '25 16:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jun 20 '25 10:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jun 23 '25 08:06 clarktsiory

PR updated with a new commit

clarktsiory avatar Jul 03 '25 08:07 clarktsiory

This PR is not mergeable to upper versions. Since it is "Ready for merge" you must merge it by yourself using the following command: rudder-dev merge https://github.com/Normation/rudder/pull/6470 -- Your faithful QA Kant merge: "Science is organized knowledge. Wisdom is organized life." (https://ci.normation.com/jenkins/job/merge-accepted-pr/103451/console)

Normation-Quality-Assistant avatar Jul 03 '25 08:07 Normation-Quality-Assistant

OK, squash merging this PR

clarktsiory avatar Jul 03 '25 08:07 clarktsiory